-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35118: [FlightSQL] Use int32
to refer to 32-bit integers rather than int
#35120
GH-35118: [FlightSQL] Use int32
to refer to 32-bit integers rather than int
#35120
Conversation
…rather than `int`
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @appletreeisyellow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thank you!
Related PR: #35108 |
Thanks again @appletreeisyellow |
Benchmark runs are scheduled for baseline = 4328eba and contender = 3ff3cc8. 3ff3cc8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…egers rather than `int` (#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue #35118. #35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: #35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
The spec is inconsistent -- see details on #35118
What changes are included in this PR?
Use
int32
to refer to 32-bit integers rather thanint
Are these changes tested?
No, only comments are changed
Are there any user-facing changes?
This clarifies a small corner case in the document